Ergo Bug List

Ergo Bug List

Web Browser

Doesn't follow applet protocols correctly. I think this is why sometimes it exits when you load another web page from nngs.cosmic.org.
Angus Stocking reports that:

Terminal window starts out too small in IE4 on NT 4.0.
Netscape 4.06 on Solaris doesn't seem to understand the JAR file format. I should still figure out how to use both JAR and non-JAR versions so it'll always work in browsers that don't know about JAR format. Here's the error message, reported by Marc Ferry:

java.io.IOException: bad zip file format

at netscape.applet.AppletClassLoader.openArchive(AppletClassLoader.java:178)

at netscape.applet.AppletClassLoader.openArchive(AppletClassLoader.java:171)

at netscape.applet.AppletClassLoader.<init>(AppletClassLoader.java:540)

at netscape.applet.AppletClassLoader.getClassLoader(AppletClassLoader.java:447)

at netscape.applet.DerivedAppletFrame$LoadAppletEvent.dispatch(DerivedAppletFrame.java:411)

at java.awt.EventDispatchThread$EventPump.dispatchEvents(EventDispatchThread.java:81)

at java.awt.EventDispatchThread.run(EventDispatchThread.java:135)

at netscape.applet.DerivedAppletFrame$AppletEventDispatchThread.run(DerivedAppletFrame.java:911)

# Unable to load archive http://nngs.cosmic.org/ergo/ergo.jar:

java.io.IOException: bad zip file format

Installation

The instructions need to be separated into Windows and Unix (and OS/2?) versions. The Windows version should not require the use of a Command Prompt window.
The init file needs to be dealt with better. When upgrading I need to say how to retain your old init file.

Smart Go Format

Ergo only supports SGF enough to read the files created by the servers.
Should probably write a semicolon (";") out before the first non-root node. i.e., "(;FF[4];B[qp]" rather than "(;FF[4]B[qp]...". (Submitted by takasan.)
Only handles valid Go moves. SGF4 doesn't require that moves be valid.
Need to ignore empty nodes.
Need to default the game size (anything else?). Currently if the SZ property is left out it assumes size 0. Should assume size 19x19 I guess.
Need better error handling around the creation of HAndicap moves. It seems that a lot of SGF apps don't follow the SGF4 spec very well.
Shouldn't write two of the same property in one node. I do this only with the Comment property, I think, for RemovalMoves
Recognize the WT and BT properties and create a game result move from them.
Not all properties are retained when an SGF file is read in and then resaved. (Hmmm, WinIGC doesn't do this either.)
The initial time field is incorrect. I just put 0 so far.
If you undo a move that had kibitzes, and then REDO THE SAME MOVE, Ergo doesn't copy the kibitz to the redone move. (i.e., the kibitz is lost.) I just need to either reuse the first Move object or copy the kibitz to the new object when it replaces the old one.
Not 100% SGF4 compatible when re-saving games that were loaded. Doesn't take care to separate properties that shouldn't be in the same node.
Ergo only supports SGF4. (Is this a problem?)

Go server protocol

Doesn't get final game result properly on IGS. (Does get the board position after scoring, but not the final message saying what the result was.)
Doesn't undo properly in teaching games on IGS.
Doesn't see the ParseException: No match at 17. Expected 'v'. Got '*'.

Not sure if it deals correctly with "21 {Match 3: foo [ 2k ] vs. bar [ 2k ] }"
Not sure if it deals correctly with "15 Game 124 I: Jr* (0 1 1) vs zhuangQ* (0 2 3)". Specifically, w.r.t. the *s.
Need to intercept the toggle command and prompt user if they attempt to turn off some messages that Ergo needs. e.g.., toggle verbose on or toggle quiet on

Game Browsing

Coool reports that if you UNDO during server scoring Ergo doesn't backup correctly. I know I put in logic for this but it may have suffered bit-rot.
If you enter scoring mode (locally) and a GameResultMove is placed, and then you exit scoring mode, the GameResultMove doesn't get undone correctly. See comment above GameResultMove.noteMoveUndone(StoneStasher).
It is possible for two variations to exist at the same point if a server move is undone, redone, and then undone again. The two moves should be merged.
Toggling browsing off in a server game should return the user to the finalServerMove().
If a game is resigned while the user is browsing, and then they close the window, it tries to unob the game.
Turning off local scoring needs to go to the end after going back to where local scoring started. (This is all only if not doing server scoring.)
When the user toggles off the Show Variations menu item, the board should be redrawn immediately without the variation letters showing.
If an undo move arrives from the server while the user is browsing, I don't think it is handled correctly. (Need to check on this.)
If you make a variation b and select the first move on that branch, and then backup one move (to where both a and b variations should be shown) only an a is drawn, but where variation b should be. This only happens when you backup to the move, not when browsing forward.
If you delete a variation at the root of the game tree the board isn't redrawn to erase the variation letter.

Game windows

Sometimes the wood-grain doesn't get drawn when a game window is created. I'm sure this is a timing problem with the thread that creates it. Refresh > Local fixes it.
Timer threads created by the game window are never killed when the game window is closed, they're just suspended.
New in Ergo 0.18: In the game window, if I raise the bar separating the board and the kibitz area, the kibitz area moves up, but it doesn't expand to fill the whole bottom area; it just stays the same size. Reported by dfan.
When I start observing a game in the middle, and it's a handicap game, the handicap stones on the board are incompletely drawn. It looks like a black stone was drawn, and then an 'a' was on top of it, but the 'a' has the board background behind it instead of the black stone. 'Rewinding' to the the beginning and 'fast-forwarding' to the end fixes it. Reported by dfan in 0.18.
Game windows are found by the names of the two players. This means if the same two players start a second game and the old game window is still around it gets re-used, which doesn't work.
If a player resigns after server scoring has been entered already, Ergo doesn't display the final result correctly. It stays in scoring mode. If you backup one move the final result is displayed.
ianm reports that the first game you observe has no wood-grain. Ergo 0.18/win95/NS 4.04 (I never saw this on the same platform in < 0.18.)
The status display area needs some graphic design.
The "say" command stores kibitzes twice; once locally and once from server.
Need to save and restore the relative sizes of the game board area and the kibitz/input area.
If you resize the board while scoring, the little squares representing captured territory don't get redrawn.
If you close a game window, choose "Yes" to save the game, then choose "Cancel" in the file dialog, the game gets unobserved anyway, though the window doesn't get closed. The whole close-window operation should be cancelled. This is only a problem for server games, since they get closed by the controller thread while the save dialog is still visible.
The old, below-the-board game status display (captured, time, komi, etc) doesn't deal well with being resized too small. The time panel gets stacked underneath the other. Probably will have to use just one Canvas down there and be more dynamic about redrawing...
The View > Show Status menu item doesn't work correctly.
The hoshi points shouldn't be drawn at all if there is a variation letter over them. Sometimes you can see part of the hoshi point, and it looks like a turd.
Some menu items don't get disabled when they are inapplicable. e.g., Pass, Undo, Done, and probably Adjourn and Resign.
The "Remove all black/white stones in region" menu item doesn't remove groups that only have libs that were in common with other groups that were removed first. (e.g., an empty triangle that was in atari.) I think this can be fixed easily by marking the edges around a removed group as not having been seen.

Text areas

Copy to the clipboard doesn't work.
Resizing the window to be more narrow doesn't always redisplay correctly. The user has to resize it again.

Games and Who windows

Linux only - double clicking on a game doesn't work to observe a game unless you've already observed a game in this session. Reported by scoffin.
We Japanese testing adapted version of Ergo (named NErgo),

They should refresh when brought to the front by the user clicking on them (if Java sends us an event for that).
When you choose the "Games" or "Who" menu items, the window should come up immediately, and then refresh itself. That way the user knows something is happening.
They can open up partially offscreen.
The column headings can get chopped off on top. That canvas should be sized to fit the max height of the font used.
They don't remember their height correctly.
View -> Refresh is the same as View -> Refresh All

General

Do what talby wants. Requested by talby.

Digital Unix, jdk 1.1.6-2 (from Henry Story)

when I start ergo a popup appears saying that it is connecting to the server. I have to hit cancel for it to move on from there. Then I get the main window. It is blank. If I type my user name it asks for the password. If I misstype the password a popup appears. I imagine the popup should appear immediately.
When I try to close a window I am observing a game in, it does not always close it. The window is still referred to in the Windows menu. (if I then open it from that menu, it creates a new window that I can no longer close)
The first game I tried I was able to use the mouse to make my moves. In the last few games though I have not been able to do this, but was forced to type each move in with the keyboard. Perhaps I set some option that I should not have touched. I tried changing every option available but with no success.

I think I have narrowed one of these problems down a little. Btw I am using java 1.1.6-2 on Digital Unix.

Yesterday I said I was not able to place the stones on the board, when playing a game with someone. For some reason I only get contacted when I am observing a game. This time I close the game I was observing and the problem dissapeared. I was able to place the stones on the board using the mouse, rather than by typing in the coordinates.

When I tried to close the game, after having finished it, the program asked me whether I wanted to save the game, and then froze.

If you have anything you would like to add to this list, please send me mail or leave me a message on NNGS (username sigue).